airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] akki commented on a change in pull request #6552: AIRFLOW-5850: Capture task logs in DockerSwarmOperator
Date Sat, 16 Nov 2019 19:20:27 GMT
akki commented on a change in pull request #6552: AIRFLOW-5850: Capture task logs in DockerSwarmOperator
URL: https://github.com/apache/airflow/pull/6552#discussion_r347103956
 
 

 ##########
 File path: airflow/contrib/operators/docker_swarm_operator.py
 ##########
 @@ -89,17 +90,22 @@ class DockerSwarmOperator(DockerOperator):
     :param tty: Allocate pseudo-TTY to the container of this service
         This needs to be set see logs of the Docker container / service.
     :type tty: bool
+    :param enable_logging: Show the application's logs in operator's logs.
+        Supported only if the Docker engine is using json-file or journald logging drivers.
+        The `tty` parameter should be set to use this with Python applications.
+    :type enable_logging: bool
     """
 
     @apply_defaults
     def __init__(
             self,
             image,
+            enable_logging=True,
             *args,
             **kwargs):
-
         super().__init__(image=image, *args, **kwargs)
 
+        self.enable_logging = enable_logging
         self.service = None
 
     def _run_image(self):
 
 Review comment:
   Airflow admins would probably require a new ticket for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message