airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] zzk-dev commented on issue #6586: [AIRFLOW-5936] Allow explicit get_pty in SSHOperator
Date Sat, 16 Nov 2019 13:26:47 GMT
zzk-dev commented on issue #6586: [AIRFLOW-5936] Allow explicit get_pty in SSHOperator
URL: https://github.com/apache/airflow/pull/6586#issuecomment-554637345
 
 
   > NICE!. Just one nit. I think this could be much nicer if you write it as "@parameterized"
test - much less code , you specify an array of input-> expected values.
   > 
   > See for example here: https://github.com/apache/airflow/blob/master/tests/contrib/hooks/test_sftp_hook.py#L205
   
   Good suggestion! But I got a question - how do I parameterize the case where `get_pty`
is not provided and the default is applied? I tried to use ``None`` but it does not work.
Or should I just remove the two test cases with no `get_pty` input?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message