airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run
Date Fri, 15 Nov 2019 19:17:34 GMT
ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep
check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r346968461
 
 

 ##########
 File path: airflow/ti_deps/deps/trigger_rule_dep.py
 ##########
 @@ -34,6 +35,31 @@ class TriggerRuleDep(BaseTIDep):
     IGNOREABLE = True
     IS_TASK_DEP = True
 
+    @staticmethod
+    def _get_states_count_upstream_ti(ti, finished_tasks):
+        """
+        :param ti the ti that we want to calculate deps for
+        :type ti airflow.models.TaskInstance
+        :param finished_tasks all the finished tasks of the dag_run
 
 Review comment:
   ```suggestion
           :param finished_tasks: all the finished tasks of the dag_run
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message