airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] yimingl17 commented on a change in pull request #6565: [AIRFLOW-5909] Enable mapping to BYTEs type to sql_to_gcs operator
Date Tue, 12 Nov 2019 23:58:56 GMT
yimingl17 commented on a change in pull request #6565: [AIRFLOW-5909] Enable mapping to BYTEs
type to sql_to_gcs operator
URL: https://github.com/apache/airflow/pull/6565#discussion_r345509202
 
 

 ##########
 File path: airflow/operators/sql_to_gcs.py
 ##########
 @@ -252,10 +252,36 @@ def _write_local_schema_file(self, cursor):
             contains the BigQuery schema fields in .json format.
         """
         schema = [self.field_to_bigquery(field) for field in cursor.description]
+        tmp_schema_file_handle = NamedTemporaryFile(delete=True)
 
 Review comment:
   Thanks @whynick1 the code and comment block has been updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message