airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj edited a comment on issue #6536: [AIRFLOW-5885] List of tests is generated by pre-commit not Docker build
Date Tue, 12 Nov 2019 00:55:34 GMT
mik-laj edited a comment on issue #6536: [AIRFLOW-5885] List of tests is generated by pre-commit
not Docker build
URL: https://github.com/apache/airflow/pull/6536#issuecomment-552681674
 
 
   Is it not possible to generate this file at another time, e.g. when starting the breeze
environment?  I am afraid that the existence of this file will cause many problems, because
it will need to be updated forever. I would prefer that every change changes only what is
necessary.  This makes it very difficult for beginners to add new functions because they may
not have pre-commit installed. pre-commit is optional, but it is recommended to use it. The
breeze environment is also optional, but it is recommended to use it. Changes to patches should
also be possible for people who do not want to use the Breeze environment. Airflow is used
by many companies and they may have their own forks, so additional files in the patch will
hinder cherry-pick.
   
   BTW. Personally, I don't use automatic completion of test names, because I prefer to specify
them by file name, and this is provided by Bash, so the necessity of completing a file that
I don't use would cause a lot of emotion if it caused problems.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message