airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] OmerJog commented on issue #6531: [AIRFLOW-5882] Add ti_dep for not being in the RUNNING state
Date Sun, 10 Nov 2019 13:34:38 GMT
OmerJog commented on issue #6531: [AIRFLOW-5882] Add ti_dep for not being in the RUNNING state
URL: https://github.com/apache/airflow/pull/6531#issuecomment-552195333
 
 
   @saguziel 
   There are style errors:
   ```
   airflow/ti_deps/deps/task_not_running_dep.py:1:0: C0111: Missing module docstring (missing-docstring)
   airflow/ti_deps/deps/task_not_running_dep.py:25:0: C0111: Missing class docstring (missing-docstring)
   airflow/ti_deps/deps/task_not_running_dep.py:36:15: C0123: Using type() instead of isinstance()
for a typecheck. (unidiomatic-typecheck)
   airflow/ti_deps/deps/task_not_running_dep.py:42:4: W0222: Signature differs from overridden
'_get_dep_statuses' method (signature-differs)
   ************* Module airflow.utils.log.json_formatter
   airflow/utils/log/json_formatter.py:1:0: R0401: Cyclic import (airflow -> airflow.executors
-> airflow.executors.kubernetes_executor -> airflow.kubernetes.pod_launcher) (cyclic-import)
   airflow/utils/log/json_formatter.py:1:0: R0401: Cyclic import (airflow.executors ->
airflow.executors.kubernetes_executor -> airflow.kubernetes.pod_generator) (cyclic-import)
   airflow/utils/log/json_formatter.py:1:0: R0401: Cyclic import (airflow.executors ->
airflow.executors.kubernetes_executor -> airflow.kubernetes.pod_launcher -> airflow.kubernetes.pod_generator)
(cyclic-import)
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message