airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj commented on a change in pull request #6495: [AIRFLOW-5829] Get rid of the checklicence image. Depends on [AIRFLOW-5827] [AIRFLOW-5830]
Date Mon, 04 Nov 2019 16:03:55 GMT
mik-laj commented on a change in pull request #6495: [AIRFLOW-5829] Get rid of the checklicence
image. Depends on [AIRFLOW-5827]  [AIRFLOW-5830]
URL: https://github.com/apache/airflow/pull/6495#discussion_r342129865
 
 

 ##########
 File path: Dockerfile
 ##########
 @@ -203,6 +203,20 @@ RUN curl -Lo kind \
    && chmod +x kind \
    && mv kind /usr/local/bin/kind
 
+ARG RAT_VERSION="0.13"
+
+ENV RAT_VERSION="${RAT_VERSION}" \
+    RAT_JAR="/tmp/apache-rat-${RAT_VERSION}.jar" \
 
 Review comment:
   Can we put it in another directory? For example `/opt/`. The /tmp/ directory is by definition
a ephemeral directory, but we want this file to exist longer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message