From commits-return-71905-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Thu Oct 24 18:05:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B63A518065D for ; Thu, 24 Oct 2019 20:05:05 +0200 (CEST) Received: (qmail 7530 invoked by uid 500); 24 Oct 2019 18:05:05 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 7520 invoked by uid 99); 24 Oct 2019 18:05:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Oct 2019 18:05:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6665A1A40AD for ; Thu, 24 Oct 2019 18:05:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -112.199 X-Spam-Level: X-Spam-Status: No, score=-112.199 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id DZ-RHG3gnSBz for ; Thu, 24 Oct 2019 18:05:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=207.244.88.153; helo=mail.apache.org; envelope-from=jira@apache.org; receiver= Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with SMTP id 8F1377F75A for ; Thu, 24 Oct 2019 18:05:02 +0000 (UTC) Received: (qmail 7098 invoked by uid 99); 24 Oct 2019 18:05:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Oct 2019 18:05:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C47B5E2EE5 for ; Thu, 24 Oct 2019 18:05:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 40CC1780259 for ; Thu, 24 Oct 2019 18:05:00 +0000 (UTC) Date: Thu, 24 Oct 2019 18:05:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-5747) Virtual env detection does not work with venv MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-5747?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 959112#comment-16959112 ]=20 ASF GitHub Bot commented on AIRFLOW-5747: ----------------------------------------- francescomucio commented on pull request #6417: [AIRFLOW-5747] `real_prefix= misses the virtual env created with pyenv=E2=80=A6 URL: https://github.com/apache/airflow/pull/6417 =20 =20 =E2=80=A6 and venv =20 Make sure you have checked _all_ steps below. =20 ### Jira =20 - [ ] My PR addresses the following [Airflow Jira](https://issues.apache= .org/jira/browse/AIRFLOW/) issues and references them in the PR title. For = example, "\[AIRFLOW-XXX\] My Airflow PR" - https://issues.apache.org/jira/browse/AIRFLOW-XXX - In case you are fixing a typo in the documentation you can prepend y= our commit with \[AIRFLOW-XXX\], code changes always need a Jira issue. - In case you are proposing a fundamental code change, you need to cre= ate an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/conflue= nce/display/AIRFLOW/Airflow+Improvements+Proposals)). - In case you are adding a dependency, check if the license complies w= ith the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolve= d.html#category-x). =20 ### Description =20 - [ ] Here are some details about my PR, including screenshots of any UI= changes: =20 ### Tests =20 - [ ] My PR adds the following unit tests __OR__ does not need testing f= or this extremely good reason: =20 ### Commits =20 - [ ] My commits all reference Jira issues in their subject lines, and I= have squashed multiple commits if they address the same issue. In addition= , my commits follow the guidelines from "[How to write a good git commit me= ssage](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue refer= ence) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" =20 ### Documentation =20 - [ ] In case of new functionality, my PR adds documentation that descri= bes how to use it. - All the public functions and the classes in the PR contain docstring= s that explain what it does - If you implement backwards incompatible changes, please leave a note= in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATIN= G.md) so we can assign it to a appropriate release =20 =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Virtual env detection does not work with venv > --------------------------------------------- > > Key: AIRFLOW-5747 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5747 > Project: Apache Airflow > Issue Type: Bug > Components: ci > Affects Versions: 2.0.0, 1.10.5 > Reporter: Jarek Potiuk > Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)