From commits-return-70995-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Fri Oct 18 09:35:07 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CF4861804BB for ; Fri, 18 Oct 2019 11:35:06 +0200 (CEST) Received: (qmail 53530 invoked by uid 500); 18 Oct 2019 09:35:06 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 53521 invoked by uid 99); 18 Oct 2019 09:35:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Oct 2019 09:35:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 84F18C22A0 for ; Fri, 18 Oct 2019 09:35:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -113 X-Spam-Level: X-Spam-Status: No, score=-113 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id TY3k3kounA9h for ; Fri, 18 Oct 2019 09:35:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=207.244.88.153; helo=mail.apache.org; envelope-from=jira@apache.org; receiver= Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with SMTP id 3EB71BC9D4 for ; Fri, 18 Oct 2019 09:35:03 +0000 (UTC) Received: (qmail 52983 invoked by uid 99); 18 Oct 2019 09:35:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Oct 2019 09:35:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B249EE30FE for ; Fri, 18 Oct 2019 09:35:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 7BA40780486 for ; Fri, 18 Oct 2019 09:35:00 +0000 (UTC) Date: Fri, 18 Oct 2019 09:35:00 +0000 (UTC) From: "ASF subversion and git services (Jira)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-4574) Add SSHHook private key parameter pkey MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-4574?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 954435#comment-16954435 ]=20 ASF subversion and git services commented on AIRFLOW-4574: ---------------------------------------------------------- Commit 0790ede70270ceb8b92f8c8df530361749221053 in airflow's branch refs/he= ads/master from dstandish [ https://gitbox.apache.org/repos/asf?p=3Dairflow.git;h=3D0790ede ] [AIRFLOW-4574] SSHHook private_key may only be supplied in extras (#6163) * discussion on original PR suggested removing private_key option as init p= aram * with this PR, can still provide through extras, but not as init param * also add support for private_key in tunnel -- missing in original PR for = this issue * remove test related to private_key init param * use context manager to auto-close socket listener so tests can be re-run > Add SSHHook private key parameter pkey > -------------------------------------- > > Key: AIRFLOW-4574 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4574 > Project: Apache Airflow > Issue Type: Improvement > Components: hooks > Reporter: Freddy Fostvedt > Assignee: Freddy Fostvedt > Priority: Minor > Fix For: 1.10.6 > > > The SSHHook only supports key_file parameter for specifying the path to a= private=C2=A0key on disk. This means that private keys for connections tha= t use ssh hooks must be stored on the disk of the worker instead of in the = connection database. Maintaining the relationship between the worker's disk= state and the connection makes deploying connection changes unnecessarily = complicated. > Paramiko, which SSHHook is built on, has support for accepting private ke= ys as an input parameter (pkey) > [https://github.com/paramiko/paramiko/blob/53095107625a1303bd9fcfcc7c2c20= b9819ee79f/paramiko/client.py#L224] > The work involved in doing=C2=A0this should only be to add pkey as a para= meter to the SSHHook constructor, and=C2=A0test that SSHConnection passes p= key to SSHHook which then passes it to Paramiko. -- This message was sent by Atlassian Jira (v8.3.4#803005)