From commits-return-73229-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Wed Oct 30 12:19:21 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 36AA4180654 for ; Wed, 30 Oct 2019 13:19:21 +0100 (CET) Received: (qmail 13675 invoked by uid 500); 30 Oct 2019 12:19:20 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 13664 invoked by uid 99); 30 Oct 2019 12:19:20 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Oct 2019 12:19:20 +0000 From: GitBox To: commits@airflow.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bairflow=5D_ashb_commented_on_issue_=236340=3A_?= =?utf-8?q?=5BAirflow-5660=5D_Try_to_find_the_task_in_DB_before_regressing?= =?utf-8?q?_to_search=E2=80=A6?= Message-ID: <157243796051.7543.15200165574121600884.gitbox@gitbox.apache.org> Date: Wed, 30 Oct 2019 12:19:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ashb commented on issue #6340: [Airflow-5660] Try to find the task in DB before regressing to search… URL: https://github.com/apache/airflow/pull/6340#issuecomment-547874314 > Only dag_id / task_id are being stored in the labels. The execution date isn't being stored there so it shouldn't be a problem. https://github.com/apache/airflow/blob/5a0ddc576a45e7c2e573eb468f4f133bd56cc03b/airflow/executors/kubernetes_executor.py#L539 begs to differ. But `_label_safe_datestring_to_datetime` and it's reverse means it's probably okay:) Final question: which log file does this warning show up in? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services