From commits-return-72451-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Sun Oct 27 02:29:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 120E9180651 for ; Sun, 27 Oct 2019 03:29:56 +0100 (CET) Received: (qmail 97814 invoked by uid 500); 27 Oct 2019 02:29:56 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 97805 invoked by uid 99); 27 Oct 2019 02:29:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Oct 2019 02:29:55 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] ashb commented on issue #5297: AIRFLOW-2143 - Fix TaskTries graph counts off-by-1 Message-ID: <157214339567.8339.7232032517302794613.gitbox@gitbox.apache.org> Date: Sun, 27 Oct 2019 02:29:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ashb commented on issue #5297: AIRFLOW-2143 - Fix TaskTries graph counts off-by-1 URL: https://github.com/apache/airflow/pull/5297#issuecomment-546655971 > That said, I do feel like the +1 behavior in `try_number` is confusing, and it's clear other committers have had to try to work around it _I_ wrote it and wasn't every happy with it. No disagreements here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services