From commits-return-70861-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Thu Oct 17 12:07:15 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E7D03180657 for ; Thu, 17 Oct 2019 14:07:14 +0200 (CEST) Received: (qmail 31533 invoked by uid 500); 17 Oct 2019 12:07:14 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 31523 invoked by uid 99); 17 Oct 2019 12:07:14 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Oct 2019 12:07:14 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] ashb commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible Message-ID: <157131403416.30406.9985899891120016201.gitbox@gitbox.apache.org> Date: Thu, 17 Oct 2019 12:07:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ashb commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible URL: https://github.com/apache/airflow/pull/6327#discussion_r335964889 ########## File path: airflow/lineage/datasets.py ########## @@ -104,13 +118,15 @@ def map_type(name): class DataBase(DataSet): + """DataBase class, subclass of DataSet.""" Review comment: This comment is almost worse than no comment at all. It doesn't tell me anything more about the class. If we aren't going to have a descriptibe doccomment that adds more info then I'd rather we just disabled the warning for these class ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services