From commits-return-70828-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Thu Oct 17 10:15:16 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EA9A3180657 for ; Thu, 17 Oct 2019 12:15:15 +0200 (CEST) Received: (qmail 24187 invoked by uid 500); 17 Oct 2019 10:15:15 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 24178 invoked by uid 99); 17 Oct 2019 10:15:15 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Oct 2019 10:15:15 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] ashb commented on a change in pull request #6321: [AIRFLOW-5649] Skips some tests for non relevant changes Message-ID: <157130731516.13397.6987094318914015446.gitbox@gitbox.apache.org> Date: Thu, 17 Oct 2019 10:15:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ashb commented on a change in pull request #6321: [AIRFLOW-5649] Skips some tests for non relevant changes URL: https://github.com/apache/airflow/pull/6321#discussion_r335923495 ########## File path: scripts/ci/_utils.sh ########## @@ -910,15 +927,39 @@ function build_image_on_ci() { # Cleanup docker installation. It should be empty in CI but let's not risk docker system prune --all --force rm -rf "${BUILD_CACHE_DIR}" + mkdir -pv "${BUILD_CACHE_DIR}" - if [[ ${TRAVIS_JOB_NAME:=""} == "Tests"* ]]; then - rebuild_ci_image_if_needed + CHANGED_FILE_NAMES=$(git diff --name-only "${TRAVIS_BRANCH:="HEAD"}...HEAD") + echo + echo "Changed file names in this commit" + echo "$CHANGED_FILE_NAMES" + echo + + if [[ ${TRAVIS_JOB_NAME:=""} == "Tests"*"kubernetes"* ]]; then + match_files_regexp 'airflow/kubernetes/.*\.py' 'tests/kubernetes/.*\.py' Review comment: I've had a few cases where bugs in my PR in the webserver code were only caught by the kube tests btw. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services