From commits-return-70432-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Tue Oct 15 12:33:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7A392180651 for ; Tue, 15 Oct 2019 14:33:08 +0200 (CEST) Received: (qmail 74100 invoked by uid 500); 15 Oct 2019 12:33:07 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 74088 invoked by uid 99); 15 Oct 2019 12:33:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Oct 2019 12:33:07 +0000 From: GitBox To: commits@airflow.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bairflow=5D_kaxil_commented_on_a_change_in_pull_?= =?utf-8?q?request_=236302=3A_=5BAIRFLOW-5636=5D_Allow_adding_or_overridin?= =?utf-8?q?g_existing_Operator_Links_for=E2=80=A6?= Message-ID: <157114278775.25921.15971686726242894178.gitbox@gitbox.apache.org> Date: Tue, 15 Oct 2019 12:33:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit kaxil commented on a change in pull request #6302: [AIRFLOW-5636] Allow adding or overriding existing Operator Links for… URL: https://github.com/apache/airflow/pull/6302#discussion_r334921782 ########## File path: airflow/models/baseoperator.py ########## @@ -566,7 +566,20 @@ def priority_weight_total(self): @cached_property def operator_extra_link_dict(self): """Returns dictionary of all extra links for the operator""" - return {link.name: link for link in self.operator_extra_links} + from airflow.plugins_manager import operator_extra_links + + op_extra_links_from_plugin = {} + for ope in operator_extra_links: Review comment: Check line 569 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services