airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5726) Delete table as file name in RedshiftToS3Transfer
Date Wed, 23 Oct 2019 14:07:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957891#comment-16957891
] 

ASF GitHub Bot commented on AIRFLOW-5726:
-----------------------------------------

JavierLopezT commented on pull request #6396: [AIRFLOW-5726] Delete table as file name in
RedshiftToS3Transfer
URL: https://github.com/apache/airflow/pull/6396
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-5726/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5726
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow
Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd
Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   Now it is possible to have whatever file name for the file that will be stored in S3 and
there is no limitation for table name. There is still the possibility to keep this choice
though.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Delete table as file name in RedshiftToS3Transfer
> -------------------------------------------------
>
>                 Key: AIRFLOW-5726
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5726
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators
>    Affects Versions: 1.10.5
>            Reporter: Javier Lopez Tomas
>            Assignee: Javier Lopez Tomas
>            Priority: Minor
>              Labels: redshift, s3
>
> Right now, if you want to unload a redshift table called 'people' to s3, in a bucket
X, key Y with name 'bad_people' you can't, and the directory is set to be s3://X/Y/people_
> This limitates your freedom to save your table with the name that you want



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message