airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5663) PythonVirtualenvOperator doesn't print logs until the operator is finished
Date Tue, 22 Oct 2019 17:53:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957243#comment-16957243
] 

ASF GitHub Bot commented on AIRFLOW-5663:
-----------------------------------------

wjiangqc commented on pull request #6389: [AIRFLOW-5663]: Switch to real-time logging in PythonVirtualenvOperator.
URL: https://github.com/apache/airflow/pull/6389
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5663
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Allow us to see the logs while the operator is running.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   Existing 19 unit tests passed.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> PythonVirtualenvOperator doesn't print logs until the operator is finished
> --------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5663
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5663
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: 1.10.5
>            Reporter: Wei Jiang
>            Priority: Major
>
> It seems the {{PythonVirtualenvOperator }}doesn't print out the log until the job is
done. When we use logging in {{PythonOperator}}, it does print out logging in real time. It
would be nice for the {{PythonVirtualenvOperator}} to have the same functionality as the
{{PythonOperator}} so we can see the logging output as the PythonVirtualenvOperator makes
progress.
> [https://github.com/apache/airflow/blob/master/airflow/operators/python_operator.py#L332]
> {code:python}
>     def _execute_in_subprocess(self, cmd):
>         try:
>             self.log.info("Executing cmd\n%s", cmd)
>             output = subprocess.check_output(cmd,
>                                              stderr=subprocess.STDOUT,
>                                              close_fds=True)
>             if output:
>                 self.log.info("Got output\n%s", output)
>         except subprocess.CalledProcessError as e:
>             self.log.info("Got error output\n%s", e.output)
>             raise
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message