airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5387) Pagination is broken when the config variable hide_paused_dags_by_default is set to True because showPaused variable is removed
Date Tue, 08 Oct 2019 15:55:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946999#comment-16946999
] 

ASF GitHub Bot commented on AIRFLOW-5387:
-----------------------------------------

feluelle commented on pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug
URL: https://github.com/apache/airflow/pull/6100
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Pagination is broken when the config variable hide_paused_dags_by_default is set to True
because showPaused variable is removed
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5387
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5387
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.10.4
>            Reporter: Guillem Lefait
>            Assignee: Alejandro
>            Priority: Minor
>
> Url parameters are clean to remove useless parameters:
> {code:python}
> // https://github.com/apache/airflow/blob/master/airflow/www/utils.py#L68-L71
>     if 'showPaused' in kwargs:
>       v = kwargs['showPaused']
>       if v or v is None:
>          kwargs.pop('showPaused')
> {code}
> When the configuration variable _hide_paused_dags_by_default_ is set to True, removing
the parameter showPaused disable access to the correct paginated pages when navigating to
"Show Paused DAGs" .
> Pagination is fine for the first page but when going on second page, only "active" DAGs
are presented.
> Fix: 
> - showPaused parameter should not be removed and therefore lines 68 to 71 (included)
could be removed.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message