airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5243) Make airflow/configuration.py and airflow/exceptions.py Pylint compatible
Date Tue, 29 Oct 2019 12:38:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961966#comment-16961966
] 

ASF GitHub Bot commented on AIRFLOW-5243:
-----------------------------------------

kik-kik commented on pull request #6459: [AIRFLOW-5243](https://issues.apache.org/jira/browse/AIRFLOW-5243)
config and exceptions pylint compliance
URL: https://github.com/apache/airflow/pull/6459
 
 
   [AIRFLOW-5243](https://issues.apache.org/jira/browse/AIRFLOW-5243) config and exceptions
pylint compliance
   
   ### Notes:
   ```airflow/configuration.py:199:4: R1710: Either all return statements in a function should
return an expression, or none of them should. (inconsistent-return-statements)
   airflow/configuration.py:205:4: R1710: Either all return statements in a function should
return an expression, or none of them should. (inconsistent-return-statements)
   airflow/configuration.py:213:4: R0911: Too many return statements (7/6) (too-many-return-statements)```
   - These 3 errors still remain and I'm not sure how to fix them, too many return statements
would require some refactoring but I'm unsure about exactly what is happening in that function.
   - I couldn't figure out how to fix the other two
   
   ### Description
   - As part of [AIRFLOW-4364 Integrate Pylint](https://issues.apache.org/jira/browse/AIRFLOW-4364)
   
   ### Tests
   - No code changes
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make airflow/configuration.py and airflow/exceptions.py Pylint compatible
> -------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5243
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5243
>             Project: Apache Airflow
>          Issue Type: Sub-task
>          Components: ci
>    Affects Versions: 2.0.0
>            Reporter: Utkarsh Jain
>            Assignee: kik
>            Priority: Major
>
> Fix all Pylint messages in airflow/configuration.py. To start; running scripts/ci/ci_pylint.sh
on master should produce no messages. 
> 1. Remove the file airflow/configuration.py from the blacklist. 
> 2. Run scripts/ci/ci_pylint_main.sh to see all messages on the no longer blacklisted
files. 
> 3. Fix all messages and create PR.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message