airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-4574) Add SSHHook private key parameter pkey
Date Fri, 18 Oct 2019 09:35:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954435#comment-16954435
] 

ASF subversion and git services commented on AIRFLOW-4574:
----------------------------------------------------------

Commit 0790ede70270ceb8b92f8c8df530361749221053 in airflow's branch refs/heads/master from
dstandish
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=0790ede ]

[AIRFLOW-4574] SSHHook private_key may only be supplied in extras (#6163)

* discussion on original PR suggested removing private_key option as init param
* with this PR, can still provide through extras, but not as init param
* also add support for private_key in tunnel -- missing in original PR for this issue
* remove test related to private_key init param
* use context manager to auto-close socket listener so tests can be re-run

> Add SSHHook private key parameter pkey
> --------------------------------------
>
>                 Key: AIRFLOW-4574
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4574
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>            Reporter: Freddy Fostvedt
>            Assignee: Freddy Fostvedt
>            Priority: Minor
>             Fix For: 1.10.6
>
>
> The SSHHook only supports key_file parameter for specifying the path to a private key
on disk. This means that private keys for connections that use ssh hooks must be stored on
the disk of the worker instead of in the connection database. Maintaining the relationship
between the worker's disk state and the connection makes deploying connection changes unnecessarily
complicated.
> Paramiko, which SSHHook is built on, has support for accepting private keys as an input
parameter (pkey)
> [https://github.com/paramiko/paramiko/blob/53095107625a1303bd9fcfcc7c2c20b9819ee79f/paramiko/client.py#L224]
> The work involved in doing this should only be to add pkey as a parameter to the SSHHook
constructor, and test that SSHConnection passes pkey to SSHHook which then passes it to Paramiko.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message