airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-4316) Keys/Variable names in the 'kubernetes_environment_variables' section are transformed to lower case
Date Fri, 04 Oct 2019 09:12:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944339#comment-16944339
] 

ASF GitHub Bot commented on AIRFLOW-4316:
-----------------------------------------

ashb commented on pull request #5379: AIRFLOW-4316 Don't make automatically lower case every
variable from …
URL: https://github.com/apache/airflow/pull/5379
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Keys/Variable names in the 'kubernetes_environment_variables' section are transformed
to lower case
> ---------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4316
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4316
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: configuration, contrib
>    Affects Versions: 1.10.3
>            Reporter: Vlad Precup
>            Assignee: QP Hou
>            Priority: Major
>              Labels: configuration, kubernetes
>             Fix For: 1.10.5
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> All the environment variable names declared under the kubernetes_environment_variables
section are converted to lowercase in the newly generated pods when running Airflow with the
KubernetesExecutor in version 1.10.3.
> The behavior is not aligned with the comments in the documentation / code comments in
the default config file, airflow.cfg.
> Investigation helper:
> Since we are treating all the sections uniformly in the configuration component, all
the keys are lowered (i.e. `configuration.py`, line 342 ->`key = env_var.replace(section_prefix,
'').lower()`)
> Please also write (a) unit test(s) for this special case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message