airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming for scheduler used slot metric
Date Wed, 30 Oct 2019 10:23:39 GMT
ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming for scheduler
used slot metric
URL: https://github.com/apache/airflow/pull/6342#discussion_r340529730
 
 

 ##########
 File path: airflow/jobs/scheduler_job.py
 ##########
 @@ -982,10 +982,13 @@ def _find_executable_task_instances(self, simple_dag_bag, states, session=None):
 
             Stats.gauge('pool.starving_tasks.{pool_name}'.format(pool_name=pool_name),
                         num_starving_tasks)
+            slots_stats = pools[pool_name].slots_stats()
             Stats.gauge('pool.open_slots.{pool_name}'.format(pool_name=pool_name),
-                        pools[pool_name].open_slots())
+                        slots_stats["open"])
 
 Review comment:
   ```suggestion
                           open_slots)
   ```
   
   Possibly. Given this local variable is what the scheduler thinks the pool open slots are,
it would make sense to report the metric on that, not based on the DB value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message