airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj commented on issue #6376: [WIP] [AIRFLOW-5705] Add creds backend classes including AWS SSM
Date Fri, 25 Oct 2019 15:36:07 GMT
mik-laj commented on issue #6376: [WIP] [AIRFLOW-5705] Add creds backend classes including
AWS SSM
URL: https://github.com/apache/airflow/pull/6376#issuecomment-546403201
 
 
   > What's the actual usecase for this? Why does the operator need to write the connection
object to the DB?
   
   This Hook retrieves authorization data for an external database based on the instance name
in GCP, and then you create a database connection so that hook (PostgresSqlHook / MySqlHook)
can read it. Hook does not accept authorization data passed in any other way than via connection.
We wanted to avoid entering an ambiguous constructor who accepted authorization data. This
could discourage users from using connections instead of creating hooks from the credentials
data.
   
   It is worth noting that for the database connection to work it is necessary to run SQL
proxy, and in the connection configuration a unique random port number and the name of the
local socket are saved
   
   > Yes, that probably seems fair (or make it read only if that's possible/sensible)
   
   In this case, he needs an additional method in our backend. Not only the get method, but
also the list method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message