airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on issue #6376: [WIP] [AIRFLOW-5705] Add creds backend classes including AWS SSM
Date Fri, 25 Oct 2019 15:15:19 GMT
ashb commented on issue #6376: [WIP] [AIRFLOW-5705] Add creds backend classes including AWS
SSM
URL: https://github.com/apache/airflow/pull/6376#issuecomment-546395246
 
 
   > @ashb I am mainly worried about backwards compatibility. Some operators are already
modifying the list of connections
   > https://github.com/apache/airflow/blob/master/airflow/gcp/hooks/cloud_sql.py#L938-L952
   > https://github.com/apache/airflow/blob/master/airflow/gcp/operators/cloud_sql.py#L838-L847
   > These operators will no longer work with other backends
   
   That fells like entirely the wrong place to touch connections in the DB. What's the actual
usecase for this? Why does the operator need to _write_ the connection object to the DB? Why
not change the hook to take a connection property somehow instead of writing and then deleting
the connection.
   
   > 
   > As for the UI, it seems to me that if it does not work at some settings then it should
be turned off in these situations.
   
   Yes, that probably seems fair (or make it read only if that's possible/sensible)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message