airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] dimberman commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test
Date Thu, 24 Oct 2019 11:48:51 GMT
dimberman commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure
in Slack test
URL: https://github.com/apache/airflow/pull/6407#discussion_r338527726
 
 

 ##########
 File path: tests/contrib/hooks/test_slack_webhook_hook.py
 ##########
 @@ -105,7 +105,7 @@ def test_build_slack_message(self):
         message = hook._build_slack_message()
 
         # Then
-        self.assertEqual(self.expected_message, message)
+        self.assertCountEqual(self.expected_message, message)
 
 Review comment:
   So why not use `assertDictEquals`? I think that ignores ordering.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message