airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]
Date Tue, 22 Oct 2019 11:42:23 GMT
ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support
including refactoring of build scripts - depends on [AIRFLOW-5704]
URL: https://github.com/apache/airflow/pull/6266#discussion_r337465801
 
 

 ##########
 File path: setup.py
 ##########
 @@ -287,46 +286,75 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
     'jira',
     'mongomock',
     'moto==1.3.5',
+    'mypy==0.720',
     'nose',
     'nose-ignore-docstring==0.2',
     'nose-timer',
     'parameterized',
-    'paramiko',
     'pre-commit',
     'pylint~=2.3.1',  # to be upgraded after fixing https://github.com/PyCQA/pylint/issues/3123
                       # We should also disable checking docstring at the module level
-    'pysftp',
-    'pywinrm',
-    'qds-sdk>=1.9.6',
     'rednose',
     'requests_mock',
     'yamllint'
 ]
+
+devel = sorted(devel + doc)
+
 ############################################################################################################
 # IMPORTANT NOTE!!!!!!!!!!!!!!!
 # IF you are removing dependencies from the above list, please make sure that you also increase
 # DEPENDENCIES_EPOCH_NUMBER in the Dockerfile
 ############################################################################################################
 
-if PY3:
-    devel += ['mypy==0.720']
-else:
-    devel += ['unittest2']
-
 devel_minreq = devel + kubernetes + mysql + doc + password + cgroups
 devel_hadoop = devel_minreq + hive + hdfs + webhdfs + kerberos
-devel_all = (sendgrid + devel + all_dbs + doc + samba + slack + oracle +
-             docker + ssh + kubernetes + celery + redis + gcp + grpc +
-             datadog + zendesk + jdbc + ldap + kerberos + password + webhdfs + jenkins +
-             druid + pinot + segment + snowflake + elasticsearch + sentry +
-             atlas + azure + aws + salesforce + cgroups + papermill + virtualenv)
 
-# Snakebite & Google Cloud Dataflow are not Python 3 compatible :'(
-if PY3:
-    devel_ci = [package for package in devel_all if package not in
-                ['snakebite>=2.7.8', 'snakebite[kerberos]>=2.7.8']]
-else:
-    devel_ci = devel_all
+all_packages = (
+    async_packages +
+    atlas +
+    all_dbs +
+    aws +
+    azure +
+    celery +
+    cgroups +
+    datadog +
+    dask +
+    databricks +
+    datadog +
+    docker +
+    druid +
+    elasticsearch +
+    gcp +
+    grpc +
+    flask_oauth +
+    jdbc +
+    jenkins +
+    kerberos +
+    kubernetes +
+    ldap +
+    oracle +
+    papermill +
+    password +
+    pinot +
+    redis +
+    salesforce +
+    samba +
+    sendgrid +
+    sentry +
+    segment +
+    slack +
+    snowflake +
+    ssh +
+    statsd +
+    virtualenv +
+    webhdfs +
+    winrm +
+    zendesk
+)
+
+# Snakebite is not Python 3 compatible :'(
+all_packages = [package for package in all_packages if not package.startswith('snakebite')]
 
 Review comment:
   There's an open issue for upgrading/replacing snakebite.
   
   Removing Kerberos: eek no definetly not. Soem enterprises need kerberos support. If it's
broken on Py3 then we need to fix that before 2.0.0 can be released.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message