airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible
Date Thu, 17 Oct 2019 12:07:14 GMT
ashb commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint
compatible
URL: https://github.com/apache/airflow/pull/6327#discussion_r335964889
 
 

 ##########
 File path: airflow/lineage/datasets.py
 ##########
 @@ -104,13 +118,15 @@ def map_type(name):
 
 
 class DataBase(DataSet):
+    """DataBase class, subclass of DataSet."""
 
 Review comment:
   This comment is almost worse than no comment at all. It doesn't tell me anything more about
the class. If we aren't going to have a descriptibe doccomment that adds more info then I'd
rather we just disabled the warning for these class

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message