airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] RosterIn commented on a change in pull request #5694: [AIRFLOW-5082] add subject in aws sns hook
Date Wed, 16 Oct 2019 21:56:23 GMT
RosterIn commented on a change in pull request #5694: [AIRFLOW-5082] add subject in aws sns
hook
URL: https://github.com/apache/airflow/pull/5694#discussion_r335727498
 
 

 ##########
 File path: tests/contrib/hooks/test_aws_sns_hook.py
 ##########
 @@ -42,9 +42,10 @@ def test_publish_to_target(self):
 
         message = "Hello world"
         topic_name = "test-topic"
+        subject = "test-subject"
         target = hook.get_conn().create_topic(Name=topic_name).get('TopicArn')
 
-        response = hook.publish_to_target(target, message)
+        response = hook.publish_to_target(target, message, subject)
 
 Review comment:
   @shaikshakeel I'm also interested in this enhancement. Are u proceeding with it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message