airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] feluelle opened a new pull request #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates skipped state
Date Wed, 16 Oct 2019 19:05:30 GMT
feluelle opened a new pull request #6352: [WIP][AIRFLOW-5683] Add SubDagOperator that propagates
skipped state
URL: https://github.com/apache/airflow/pull/6352
 
 
   ### Jira
   
     - https://issues.apache.org/jira/browse/AIRFLOW-5683
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Currently there is no way of telling the parent dag of a sub dag that an _essential_ task
has been **skipped**. This PR addresses this issue by adding a new BaseSubDag model that is
being used in an _advanced_ SubDagOperator. If you think it would make more sense to add it
directly to the SubDagOperator class I will do it, but for now I wanted to make it backwards
compatible.
   
   I also understand that this adds a new concept when dealing with subdags. So I am total
fine with it if you think this does not fit into the official airflow code. It probably can
be designed better than this. (And also the naming `Advanced` :D)
   
   **Please let me know what you guys think about this.**
   
   _Background story:_ https://lists.apache.org/thread.html/0eefd459a502c5100d792416f8ba720302aa49a8906fe6ea4ec8fca4@%3Cdev.airflow.apache.org%3E
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message