airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6302: [AIRFLOW-5636] Allow adding or overriding existing Operator Links for…
Date Tue, 15 Oct 2019 10:06:03 GMT
ashb commented on a change in pull request #6302: [AIRFLOW-5636] Allow adding or overriding
existing Operator Links for…
URL: https://github.com/apache/airflow/pull/6302#discussion_r334862264
 
 

 ##########
 File path: airflow/plugins_manager.py
 ##########
 @@ -205,6 +219,10 @@ def make_module(name, objects):
     if p.stat_name_handler:
         stat_name_handlers.append(p.stat_name_handler)
     global_operator_extra_links.extend(p.global_operator_extra_links)
+    # Only register Operator links if its ``operators`` property is not None
+    # So that we can only attach this links to a specific Operator
+    operator_extra_links.extend([
+        ope for ope in p.operator_extra_links if ope.operators is not None])
 
 Review comment:
   `if ope.operators` if we change it to not be Optional

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message