airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #5913: [AIRFLOW-5073] Change SQLSensor to treat NULL failure
Date Mon, 14 Oct 2019 20:48:03 GMT
ashb commented on a change in pull request #5913: [AIRFLOW-5073] Change SQLSensor to treat
NULL failure
URL: https://github.com/apache/airflow/pull/5913#discussion_r334656308
 
 

 ##########
 File path: airflow/sensors/sql_sensor.py
 ##########
 @@ -102,6 +98,4 @@ def poke(self, context):
                 return self.success(first_cell)
             else:
                 raise AirflowException("self.success is present, but not callable -> {}".format(self.success))
-        if self.allow_null:
-            return str(first_cell) not in ('0', '')
         return str(first_cell) not in ('0', '', 'None')
 
 Review comment:
   No, just a separate PR agsint the master branch (as we need the change against  this line
- `str(first_cell) not in ('0', '', 'None')`) Once that is in master I will cherry-pick it
back to the release branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message