airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] jojo19893 commented on a change in pull request #6303: AIRFLOW-5126 Read aws_session_token in extra_config of the aws hook
Date Mon, 14 Oct 2019 14:12:23 GMT
jojo19893 commented on a change in pull request #6303: AIRFLOW-5126 Read aws_session_token
in extra_config of the aws hook
URL: https://github.com/apache/airflow/pull/6303#discussion_r334502306
 
 

 ##########
 File path: airflow/contrib/hooks/aws_hook.py
 ##########
 @@ -111,6 +111,8 @@ def _get_credentials(self, region_name):
                         'aws_access_key_id']
                     aws_secret_access_key = extra_config[
                         'aws_secret_access_key']
+                    # If there is an external session token use this token
+                    aws_session_token = extra_config['aws_session_token']
 
 Review comment:
   okay I agree that we should check because of the exception. 
   Also then I would move it to the very bottom of the if statement and check if the session
token is empty before.
   Also extended test and ocs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message