airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj commented on a change in pull request #6306: [AIRFLOW-5632] Rename ComputeEngine operators
Date Sun, 13 Oct 2019 12:57:48 GMT
mik-laj commented on a change in pull request #6306: [AIRFLOW-5632] Rename ComputeEngine operators
URL: https://github.com/apache/airflow/pull/6306#discussion_r334277018
 
 

 ##########
 File path: tests/gcp/hooks/test_gcp_compute_hook.py
 ##########
 @@ -67,16 +67,15 @@ def test_start_instance_overridden_project_id(self, wait_for_operation_to_comple
         start_method.assert_called_once_with(instance='instance', project='example-project',
zone='zone')
         execute_method.assert_called_once_with(num_retries=5)
         wait_for_operation_to_complete.assert_called_once_with(project_id='example-project',
-                                                               operation_name='operation_id',
 
 Review comment:
   Can you remote this unrelated change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message