airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] kpathak13 commented on a change in pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call
Date Wed, 02 Oct 2019 15:40:46 GMT
kpathak13 commented on a change in pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher
in terminate call
URL: https://github.com/apache/airflow/pull/6237#discussion_r330625024
 
 

 ##########
 File path: airflow/executors/kubernetes_executor.py
 ##########
 @@ -576,6 +576,7 @@ def _labels_to_key(self, labels):
     def terminate(self):
         """Termninates the watcher."""
         self.watcher_queue.join()
+        self.kube_watcher.join()
 
 Review comment:
   Thanks @ashb. I have added `terminate` call. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message