From commits-return-67027-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Wed Sep 18 17:05:09 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A4A08180634 for ; Wed, 18 Sep 2019 19:05:09 +0200 (CEST) Received: (qmail 99351 invoked by uid 500); 18 Sep 2019 17:05:09 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 99342 invoked by uid 99); 18 Sep 2019 17:05:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Sep 2019 17:05:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8695C180D14 for ; Wed, 18 Sep 2019 17:05:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -112.19 X-Spam-Level: X-Spam-Status: No, score=-112.19 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id V9nuPaYD6sU0 for ; Wed, 18 Sep 2019 17:05:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=207.244.88.153; helo=mail.apache.org; envelope-from=jira@apache.org; receiver= Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with SMTP id 4716ABC553 for ; Wed, 18 Sep 2019 17:05:03 +0000 (UTC) Received: (qmail 99223 invoked by uid 99); 18 Sep 2019 17:05:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Sep 2019 17:05:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AC873E3141 for ; Wed, 18 Sep 2019 17:05:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 6714F78046C for ; Wed, 18 Sep 2019 17:05:00 +0000 (UTC) Date: Wed, 18 Sep 2019 17:05:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-5519) Fix missing apply default in sql_to_gcs operator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-5519?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 932674#comment-16932674 ]=20 ASF GitHub Bot commented on AIRFLOW-5519: ----------------------------------------- yimingl17 commented on pull request #6146: [AIRFLOW-5519] Fix sql_to_gcs op= erator missing multi-level default args by adding apply_defaults decorator= =20 URL: https://github.com/apache/airflow/pull/6146 =20 =20 Make sure you have checked _all_ steps below. =20 ### Jira =20 - [ ] My PR addresses the following [Airflow Jira](https://issues.apache= .org/jira/browse/AIRFLOW/) issues and references them in the PR title.=20 - https://issues.apache.org/jira/browse/AIRFLOW-5519 =20 ### Description =20 - [ ] Here are some details about my PR, including screenshots of any UI= changes: The apply_defaults decorator is missing in sql_to_gcs operator (BaseSQLT= oGoogleCloudStorageOperator), which will cause missing multi-level default = args such as google_cloud_storage_conn_id.=20 =20 =20 ### Tests =20 - [ ] My PR adds the following unit tests __OR__ does not need testing f= or this extremely good reason: =20 ### Commits =20 - [ ] My commits all reference Jira issues in their subject lines, and I= have squashed multiple commits if they address the same issue. In addition= , my commits follow the guidelines from "[How to write a good git commit me= ssage](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue refer= ence) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" =20 ### Documentation =20 - [ ] In case of new functionality, my PR adds documentation that descri= bes how to use it. - All the public functions and the classes in the PR contain docstring= s that explain what it does - If you implement backwards incompatible changes, please leave a note= in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATIN= G.md) so we can assign it to a appropriate release =20 =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Fix missing apply default in sql_to_gcs operator > ------------------------------------------------ > > Key: AIRFLOW-5519 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5519 > Project: Apache Airflow > Issue Type: Bug > Components: operators > Affects Versions: 1.10.4 > Reporter: Yiming Liu > Assignee: Yiming Liu > Priority: Major > > =C2=A0 > We don't have a apply_defaults decorator in sql_to_gcs operator, which wi= ll cause multi-level argument defaults missing.=C2=A0 -- This message was sent by Atlassian Jira (v8.3.4#803005)