From commits-return-64281-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Mon Sep 2 04:23:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A7C7D180668 for ; Mon, 2 Sep 2019 06:23:06 +0200 (CEST) Received: (qmail 64016 invoked by uid 500); 2 Sep 2019 04:23:06 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 64007 invoked by uid 99); 2 Sep 2019 04:23:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Sep 2019 04:23:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5BB67C1E2A for ; Mon, 2 Sep 2019 04:23:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -112.199 X-Spam-Level: X-Spam-Status: No, score=-112.199 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ILIp7ADEuiOT for ; Mon, 2 Sep 2019 04:23:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=207.244.88.153; helo=mail.apache.org; envelope-from=jira@apache.org; receiver= Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with SMTP id 809257D3FC for ; Mon, 2 Sep 2019 04:23:02 +0000 (UTC) Received: (qmail 63992 invoked by uid 99); 2 Sep 2019 04:23:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Sep 2019 04:23:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9BF5EE2EDE for ; Mon, 2 Sep 2019 04:23:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 0F9E2780996 for ; Mon, 2 Sep 2019 04:23:00 +0000 (UTC) Date: Mon, 2 Sep 2019 04:23:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-5129) Add typehint to gcp_dlp_hook.py MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-5129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920609#comment-16920609 ] ASF GitHub Bot commented on AIRFLOW-5129: ----------------------------------------- ryanyuan commented on pull request #5980: [AIRFLOW-5129] Add typehint to GCP DLP hook URL: https://github.com/apache/airflow/pull/5980 [AIRFLOW-5129] Add typehint to GCP DLP hook Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow-5129](https://issues.apache.org/jira/browse/AIRFLOW-5129) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR" ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: Add typehint to GCP DLP hook airflow/gcp/hooks/dlp.py ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain docstrings that explain what it does - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release ### Code Quality - [ ] Passes `flake8` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Add typehint to gcp_dlp_hook.py > ------------------------------- > > Key: AIRFLOW-5129 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5129 > Project: Apache Airflow > Issue Type: Improvement > Components: gcp > Affects Versions: 1.10.3 > Reporter: Ryan Yuan > Assignee: Ryan Yuan > Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.2#803003)