From commits-return-67710-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Tue Sep 24 10:26:17 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4F568180644 for ; Tue, 24 Sep 2019 12:26:17 +0200 (CEST) Received: (qmail 14331 invoked by uid 500); 24 Sep 2019 10:26:16 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 14307 invoked by uid 99); 24 Sep 2019 10:26:16 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Sep 2019 10:26:16 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] ashb commented on a change in pull request #6174: [AIRFLOW-5543] Fix tooltip disappears in tree and graph view Message-ID: <156932077668.24878.3696032218073746419.gitbox@gitbox.apache.org> Date: Tue, 24 Sep 2019 10:26:16 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ashb commented on a change in pull request #6174: [AIRFLOW-5543] Fix tooltip disappears in tree and graph view URL: https://github.com/apache/airflow/pull/6174#discussion_r327536928 ########## File path: airflow/www/static/js/graph.js ########## @@ -44,7 +43,10 @@ function update_nodes_states(task_instances) { tt += "Duration: " + escapeHtml(convertSecsToHumanReadable(ti.duration)) + "
"; tt += "Started: " + escapeHtml(ti.start_date) + "
"; tt += generateTooltipDateTime(ti.start_date, ti.end_date, dagTZ); // dagTZ has been defined in dag.html - return tt; + taskTip.show(tt, this); // taskTip is defined in graph.html + }) + .on('mouseout', function(d,i) { Review comment: Can be simpler: ```suggestion .on('mouseout', taskTip.hide)) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services