From commits-return-66275-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Sat Sep 14 06:22:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3680A180637 for ; Sat, 14 Sep 2019 08:22:02 +0200 (CEST) Received: (qmail 74268 invoked by uid 500); 14 Sep 2019 06:22:01 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 74257 invoked by uid 99); 14 Sep 2019 06:22:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Sep 2019 06:22:01 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] TobKed commented on a change in pull request #6099: [AIRFLOW-5479] Normalize gcp_conn method in GCP Kubernetes Hook Message-ID: <156844212105.8722.10917120946643876370.gitbox@gitbox.apache.org> Date: Sat, 14 Sep 2019 06:22:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit TobKed commented on a change in pull request #6099: [AIRFLOW-5479] Normalize gcp_conn method in GCP Kubernetes Hook URL: https://github.com/apache/airflow/pull/6099#discussion_r324414172 ########## File path: airflow/gcp/hooks/kubernetes_engine.py ########## @@ -58,7 +58,7 @@ def __init__( self._client = None self.location = location - def get_client(self) -> container_v1.ClusterManagerClient: Review comment: Sure. I've added it. Please check is it correct. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services