From commits-return-64414-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Mon Sep 2 17:57:52 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id F0AFE180658 for ; Mon, 2 Sep 2019 19:57:51 +0200 (CEST) Received: (qmail 29587 invoked by uid 500); 2 Sep 2019 19:35:56 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 29578 invoked by uid 99); 2 Sep 2019 19:35:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Sep 2019 19:35:56 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] mik-laj commented on a change in pull request #5987: [AIRFLOW-5388] Add airflow version label to newly created buckets Message-ID: <156744707130.17325.3378977203516123780.gitbox@gitbox.apache.org> Date: Mon, 02 Sep 2019 17:57:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mik-laj commented on a change in pull request #5987: [AIRFLOW-5388] Add airflow version label to newly created buckets URL: https://github.com/apache/airflow/pull/5987#discussion_r320027504 ########## File path: airflow/contrib/hooks/gcs_hook.py ########## @@ -439,6 +440,10 @@ def create_bucket(self, self.log.info('Creating Bucket: %s; Location: %s; Storage Class: %s', bucket_name, location, storage_class) + # Add airflow-version label to the bucket + labels = {} or labels + labels['airflow-version'] = 'v' + version.replace('.', '-').replace('+', '-') Review comment: Do you think we should rethink the recommendation written in this integration guide? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services