From commits-return-64290-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Mon Sep 2 07:13:52 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 25178180658 for ; Mon, 2 Sep 2019 09:13:52 +0200 (CEST) Received: (qmail 50166 invoked by uid 500); 2 Sep 2019 07:27:58 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 50157 invoked by uid 99); 2 Sep 2019 07:27:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Sep 2019 07:27:58 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] TobKed commented on a change in pull request #5980: [AIRFLOW-5129] Add typehint to GCP DLP hook Message-ID: <156740843140.15431.17810411841219153865.gitbox@gitbox.apache.org> Date: Mon, 02 Sep 2019 07:13:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit TobKed commented on a change in pull request #5980: [AIRFLOW-5129] Add typehint to GCP DLP hook URL: https://github.com/apache/airflow/pull/5980#discussion_r319830613 ########## File path: airflow/gcp/hooks/dlp.py ########## @@ -531,9 +552,13 @@ def delete_deidentify_template( project_id = project_id or self.project_id if organization_id: - name = DlpServiceClient.organization_deidentify_template_path(organization_id, template_id) + name = DlpServiceClient.organization_deidentify_template_path( + organization_id, template_id + ) Review comment: **Black** by default is set to 88. This value is not obvious. Here is explanation: https://github.com/psf/black#line-length ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services