From commits-return-64223-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Sun Sep 1 02:07:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 469E918063F for ; Sun, 1 Sep 2019 04:07:57 +0200 (CEST) Received: (qmail 94575 invoked by uid 500); 1 Sep 2019 02:07:56 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 94562 invoked by uid 99); 1 Sep 2019 02:07:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Sep 2019 02:07:56 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] mik-laj commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement Message-ID: <156730367572.727.8058137628025551539.gitbox@gitbox.apache.org> Date: Sun, 01 Sep 2019 02:07:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mik-laj commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement URL: https://github.com/apache/airflow/pull/5770#issuecomment-526879426 Unit tests for GCS Hook is available here: https://github.com/apache/airflow/blob/master/tests/contrib/hooks/test_gcs_hook.py When it comes to writing tests for GCP integration, we distinguish two types: * Unit tests - It uses very actively mocking. You should never use authorization data in these tests. Method calls from the Google library should be mocked. * System tests - It uses real DAG examples and uses authorization data. Unfortunately, they are not yet automatically launched on CI. Hooks and operators are tested using unit tests, but whole integration is tested using system tests. I hope you will write unit tests. System tests for integration with GCS have not yet been approved, but there is open PR: https://github.com/apache/airflow/pull/5951 My team has been actively working over the past two weeks to increase system test coverage. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services