airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5560) backfill command needs a 'no confirm' option
Date Fri, 27 Sep 2019 07:39:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939188#comment-16939188
] 

ASF GitHub Bot commented on AIRFLOW-5560:
-----------------------------------------

robinedwards commented on pull request #6197: [AIRFLOW-5560] Allow no confirmation on reset
dags
URL: https://github.com/apache/airflow/pull/6197
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-5560\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5560
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   When using the backfill command with the `--reset_dags` option there is a confirmation
prompt and no way to suppress it. I've wired in the `--yes` parameter to do this, note that
using `--no_confirm` wasn't an option as thats aliased to '-c' which is used for `--conf`
in the backfill sub command.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   No tests for command line flags, tested locally though.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
   - Done automatically via argparse
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> backfill command needs a 'no confirm' option
> --------------------------------------------
>
>                 Key: AIRFLOW-5560
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5560
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: backfill
>    Affects Versions: 1.10.5
>            Reporter: Robin Edwards
>            Assignee: Robin Edwards
>            Priority: Trivial
>
> airflow backfill --reset_dagruns
> has no option for overriding the clear confirmation prompt.
> provided PR does this via --yes (note the clears --no_confirm is unavailable as it conflicts
with backfill --conf=-c)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message