airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5533) CRON job fails when running static checks
Date Tue, 24 Sep 2019 09:41:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16936615#comment-16936615
] 

ASF subversion and git services commented on AIRFLOW-5533:
----------------------------------------------------------

Commit b5b3dbe76efac44d6aef08de5f87169164f2095a in airflow's branch refs/heads/v1-10-test
from Jarek Potiuk
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=b5b3dbe ]

[AIRFLOW-5533] Fixed failing CRON build

This change optimises further image building and removes unnecessary
verbosity in building the images for CI builds.

After this change is merged, only the necessary images are built for
each type of check:
* Tests -> only CI
* Static checks (with/without pylint) -> Only CI_SLIM
* Docs -> only CI_SLIM
* Licence checks -> Only CHECKLICENCE

Previously the right images only were built in ci_before_install.sh
but then in case of static checks, the pre-commit build image step
also rebuilt CHECKLICENCE and CI images - which was not necessary
and very long in case of CRON job - this caused the CRON job to
fail at 10m of inactivity.


> CRON job fails when running static checks
> -----------------------------------------
>
>                 Key: AIRFLOW-5533
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5533
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.5
>            Reporter: Jarek Potiuk
>            Priority: Major
>             Fix For: 1.10.6
>
>
> CRON job fails on static checks.
> This is because the whole image is rebuilt from the scratch and it turned out that while
running static checks it was also rebuilding CI/CHECKLICENCE images even though they were
not needed (only CI_SLIM) images are needed for static checks.
> This was done in silent mode and took long time (because it is build from the scratch)
resulting in 10m inactivity. It also means that the builds on CI can be still sped up because
the images are also being built without a need in regular jobs (but faster).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message