airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5519) Fix missing apply default in sql_to_gcs operator
Date Wed, 18 Sep 2019 17:05:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932674#comment-16932674
] 

ASF GitHub Bot commented on AIRFLOW-5519:
-----------------------------------------

yimingl17 commented on pull request #6146: [AIRFLOW-5519] Fix sql_to_gcs operator missing
multi-level default args by adding apply_defaults decorator 
URL: https://github.com/apache/airflow/pull/6146
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. 
     - https://issues.apache.org/jira/browse/AIRFLOW-5519
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   The apply_defaults decorator is missing in sql_to_gcs operator (BaseSQLToGoogleCloudStorageOperator),
which will cause missing multi-level default args such as google_cloud_storage_conn_id. 
   
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix missing apply default in sql_to_gcs operator
> ------------------------------------------------
>
>                 Key: AIRFLOW-5519
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5519
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: 1.10.4
>            Reporter: Yiming Liu
>            Assignee: Yiming Liu
>            Priority: Major
>
>  
> We don't have a apply_defaults decorator in sql_to_gcs operator, which will cause multi-level
argument defaults missing. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message