airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (Jira)" <j...@apache.org>
Subject [jira] [Created] (AIRFLOW-5485) scheduler_job: replace == with is comparison
Date Fri, 13 Sep 2019 21:59:00 GMT
Jakob Homan created AIRFLOW-5485:
------------------------------------

             Summary: scheduler_job: replace == with is comparison
                 Key: AIRFLOW-5485
                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5485
             Project: Apache Airflow
          Issue Type: Bug
          Components: hooks
    Affects Versions: 1.10.6
            Reporter: Jakob Homan


Note: This ticket's being created to facilitate a new contributor's workshop for Airflow.
After the workshop has completed, I'll mark these all available for anyone that might like
to take them on.

airflow/jobs/scheduler_job.py:855
{code:java}
.filter(or_(DR.run_id == None,  # noqa: E711 pylint: disable=singleton-comparison
            not_(DR.run_id.like(BackfillJob.ID_PREFIX + '%'))))
.outerjoin(DM, DM.dag_id == TI.dag_id)
.filter(or_(DM.dag_id == None,  # noqa: E711 pylint: disable=singleton-comparison
        not_(DM.is_paused))) {code}
We're using `==` here where we should use `is`. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message