airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5442) Druid broker hook get pandas DataFrame implementation
Date Sun, 08 Sep 2019 13:36:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925170#comment-16925170
] 

ASF GitHub Bot commented on AIRFLOW-5442:
-----------------------------------------

blcksrx commented on pull request #6057: [AIRFLOW-5442] implementing get_pandas_df method
for druid broker hook
URL: https://github.com/apache/airflow/pull/6057
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow
Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd
Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   The druid broker hook use pydruid to make contact with druid and as pydruid has sqlalchemy
implementation and the DbApiHook use sqlalchmey to return pandas dataframe from a query theres
no need to override this method on the DruidDbApiHook and returning NotImplementedError is
wrong at all!
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Druid broker hook get pandas DataFrame implementation
> -----------------------------------------------------
>
>                 Key: AIRFLOW-5442
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5442
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>    Affects Versions: 1.10.5
>            Reporter: Sayed Mohammad Hossein Torabi
>            Assignee: Sayed Mohammad Hossein Torabi
>            Priority: Minor
>
> The  *get_pandas_df* of *DruidDbApiHook* returns NotImplementedError.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message