airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5437) When you run Breeze, no matter what image is build python 3.5 from checks overrides run version
Date Tue, 10 Sep 2019 10:27:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926493#comment-16926493
] 

ASF subversion and git services commented on AIRFLOW-5437:
----------------------------------------------------------

Commit 3121add84f479bb0668c1ec1a8f369f5277c35f7 in airflow's branch refs/heads/v1-10-test
from Jarek Potiuk
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=3121add ]

[AIRFLOW-5437] Better python version detection/explanation. (#6060)

We have fairly complex python version detection in our CI scripts.

They have to handle several cases:

1) Running builds on DockerHub (we cannot pass different environment
   variables there, so we detect python version based on the image
   name being build (airflow:master-python3.7 -> PYTHON_VERSION=3.7)

2) Running builds on Travis CI. We use python version determined
   from default python3 version available on the path. This way we
   do not have to specify PYTHON_VERSION separately in each job,
   we just specify which host python version is used for that job.
   This makes a nice UI experience where you see python version in
   Travis UI.

3) Running builds locally via scripts where we can pass PYTHON_VERSION
   as environment variable.

4) Running builds locally for the first time with Breeze. By default
   we determine the version based on default python3 version we have
   in the host system (3.5, 3.6 or 3.7) and we use this one.

5) Selecting python version with Breeze's --python switch. This will
   override python version but it will also store the last used version
   of python in .build directory so that it is automatically used next
   time.

This change adds necessary explanations to the code that works for
all the cases and fixes some of the edge-cases we had. It also
extracts the code to common directory.

(cherry picked from commit 455eb41ba65af1bf7f9d2caea7393f3b82b8c1d7)


> When you run Breeze, no matter what image is build python 3.5 from checks overrides run
version
> -----------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5437
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5437
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.5
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> When you run breeze, it rebuilds several images and overrides python to 3.5 version.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message