airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5371) Yamllint is not needed as prerequisite for pre-commit
Date Mon, 02 Sep 2019 00:06:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920539#comment-16920539
] 

ASF GitHub Bot commented on AIRFLOW-5371:
-----------------------------------------

potiuk commented on pull request #5977: [AIRFLOW-5371] Remove yamllint as prerequisite to
run pre-commit
URL: https://github.com/apache/airflow/pull/5977
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5371
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   No yamllint needs to be installed in host to run pre-commits.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Yamllint is not needed as prerequisite for pre-commit
> -----------------------------------------------------
>
>                 Key: AIRFLOW-5371
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5371
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.5
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> Yamlint can be changed to python hook and have "additional_dependencies" so that pre-commit
will install it automatically. No need to have it as pre-requisite.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message