airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5369) Add interactivity to pre-commit image building
Date Sun, 01 Sep 2019 23:08:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920530#comment-16920530
] 

ASF GitHub Bot commented on AIRFLOW-5369:
-----------------------------------------

potiuk commented on pull request #5976: [AIRFLOW-5369] Add interactivity to pre-commits
URL: https://github.com/apache/airflow/pull/5976
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5369
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
       1) If image gets out-dated a question is asked whether to
          rebuild it while pre-commit is executed
   
       2) If you run pre-commit directly and need rebuild image, you do not get asked
          for rebuild because you can run multiple pre-commit scripts
          in parallel (pre-commit does it) so you should fail fast
          (with helpful instructions)
   
       3) If you run pre-commit via breeze, it is optimised because
          only the image that is actually needed
          is rebuilt (and question is asked then)
   
       4) Additionally - you should be able to press ^C and kill
          all containers running in the background as well as the main script.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   No tests for bash scripts (maybe we should add them eventually!)
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add interactivity to pre-commit image building
> ----------------------------------------------
>
>                 Key: AIRFLOW-5369
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5369
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.5
>            Reporter: Jarek Potiuk
>            Assignee: Jarek Potiuk
>            Priority: Major
>
> Currently when images are out-dated for pre-commit it just fails with message how to
re-run it with rebuild next time. Also when you already run pre-commit, ^C does not work as
expected - the main script is killed but the docker images running the checks continue running
in the background until they finish. This is pretty annoying as killing such running docker
containers is not trivial and for pylint/mypy/flake we can run multiple containers if we run
it on many modified files. This is because wer are not using dumb-init to run the checks.
>  
> This is discouraging a bit, so instead a bit of interactivity can be added:
> 1) If image gets out-dated a question is asked whether to rebuild it while pre-commit
is executed
> 2) If you run pre-commit directly you do not get asked for rebuild because you can run
multiple pre-commit scripts in parallel  (pre-commit does it) so you should fail fast (with
helpful instructions)
> 3) If you run pre-commit via breeze, it is optimised because only the image that is actually
needed is rebuilt (and question is asked then)
> 4) Additionally - you should be able to press ^C and kill all containers running in the
background as well as the main script. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message