airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5369) Add interactivity to pre-commit image building
Date Wed, 18 Sep 2019 11:44:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932331#comment-16932331
] 

ASF GitHub Bot commented on AIRFLOW-5369:
-----------------------------------------

potiuk commented on pull request #5976: [AIRFLOW-5369] Add interactivity to pre-commits
URL: https://github.com/apache/airflow/pull/5976
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add interactivity to pre-commit image building
> ----------------------------------------------
>
>                 Key: AIRFLOW-5369
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5369
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.5
>            Reporter: Jarek Potiuk
>            Assignee: Jarek Potiuk
>            Priority: Major
>
> Currently when images are out-dated for pre-commit it just fails with message how to
re-run it with rebuild next time. Also when you already run pre-commit, ^C does not work as
expected - the main script is killed but the docker images running the checks continue running
in the background until they finish. This is pretty annoying as killing such running docker
containers is not trivial and for pylint/mypy/flake we can run multiple containers if we run
it on many modified files. This is because wer are not using dumb-init to run the checks.
>  
> This is discouraging a bit, so instead a bit of interactivity can be added:
> 1) If image gets out-dated a question is asked whether to rebuild it while pre-commit
is executed
> 2) If you run pre-commit directly you do not get asked for rebuild because you can run
multiple pre-commit scripts in parallel  (pre-commit does it) so you should fail fast (with
helpful instructions)
> 3) If you run pre-commit via breeze, it is optimised because only the image that is actually
needed is rebuilt (and question is asked then)
> 4) Additionally - you should be able to press ^C and kill all containers running in the
background as well as the main script. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message