airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5088) To implement DAG JSON serialization and DB persistence for webserver scalability improvement
Date Tue, 03 Sep 2019 11:08:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921339#comment-16921339
] 

ASF GitHub Bot commented on AIRFLOW-5088:
-----------------------------------------

kaxil commented on pull request #5992: [AIRFLOW-5088][AIP-24][BackPort] Persisting serialized
DAG in DB for webserver scalability
URL: https://github.com/apache/airflow/pull/5992
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5088
     - https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-24+DAG+Persistence+in+DB+using+JSON+for+Airflow+Webserver+and+%28optional%29+Scheduler
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   **Backport of https://github.com/apache/airflow/pull/5743 for v1-10-* branches **
   Based on #5701, this PR implements functionalities including writing serialized DAGs to
DB in scheduler, reading DAGs from DB in webserver, controlled by [core] dagcached
   
   The goal is to decouple webserver from the DAG folder, instead it reads everything from
database.
   
   Rendering template by functions is an exception, in that case it needs to re-import DAG,
because functions are stringified in serialized DAG.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> To implement DAG JSON serialization and DB persistence for webserver scalability improvement
> --------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5088
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5088
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: DAG, webserver
>    Affects Versions: 1.10.5
>            Reporter: Zhou Fang
>            Assignee: Zhou Fang
>            Priority: Major
>
> Created this issue for starting to implement DAG serialization using JSON and persistence
in DB. Serialized DAG will be used in webserver for solving the webserver scalability issue.
>  
> The implementation is based on AIP-24: [https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-24+DAG+Persistence+in+DB+using+JSON+for+Airflow+Webserver+and+%28optional%29+Scheduler]
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message